Class: RuboCop::Cop::FormulaAuditStrict::RustCheck Private

Inherits:
RuboCop::Cop::FormulaCop show all
Extended by:
AutoCorrector
Defined in:
rubocops/lines.rb

Overview

This class is part of a private API. This class may only be used in the Homebrew/brew repository. Third parties should avoid using this class if possible, as it may be removed or changed without warning.

This cop makes sure that formulae build with rust instead of rustup-init.

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #caveats_strings, #depends_on?, #depends_on_name_type?, #formula_tap, #get_checksum_node, #on_class, #style_exceptions_dir, #tap_style_exception?, #versioned_formula?

Methods included from HelperFunctions

#block_method_called_in_block?, #block_size, #check_precedence, #class_name, #component_precedes?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_name, #node_equals?, #offending_node, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content

Instance Method Details

#audit_formula(_node, _class_node, _parent_class_node, body_node) ⇒ Object

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning. 



902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
 
# File 'rubocops/lines.rb', line 902

def audit_formula(_node, _class_node, _parent_class_node, body_node)
  return if body_node.nil?

  # Enforce use of `rust` for rust dependency in core
  return if formula_tap != "homebrew-core"

  find_method_with_args(body_node, :depends_on, "rustup-init") do
    problem "Formulae in homebrew/core should use 'depends_on \"rust\"' " \
            "instead of '#{@offensive_node.source}'." do |corrector|
      corrector.replace(@offensive_node.source_range, "depends_on \"rust\"")
    end
  end

  # TODO: Enforce order of dependency types so we don't need to check for
  #       depends_on "rustup-init" => [:test, :build]
  [:build, [:build, :test], [:test, :build]].each do |type|
    find_method_with_args(body_node, :depends_on, "rustup-init" => type) do
      problem "Formulae in homebrew/core should use 'depends_on \"rust\" => #{type}' " \
              "instead of '#{@offensive_node.source}'." do |corrector|
        corrector.replace(@offensive_node.source_range, "depends_on \"rust\" => #{type}")
      end
    end
  end

  install_node = find_method_def(body_node, :install)
  return if install_node.blank?

  find_every_method_call_by_name(install_node, :system).each do |method|
    param = parameters(method).first
    next if param.blank?
    # FIXME: Handle Pathname parameters (e.g. `system bin/"rustup-init"`).
    next if regex_match_group(param, /rustup-init$/).blank?

    problem "Formula in homebrew/core should not use `rustup-init` at build-time."
  end
end