Class: RuboCop::Cop::FormulaAuditStrict::MakeCheck

Inherits:
RuboCop::Cop::FormulaCop show all
Defined in:
brew/Library/Homebrew/rubocops/lines.rb

Constant Summary collapse

MAKE_CHECK_ALLOWLIST = 
%w[
  beecrypt
  ccrypt
  git
  gmp
  gnupg
  gnupg@1.4
  google-sparsehash
  jemalloc
  jpeg-turbo
  mpfr
  nettle
  open-mpi
  openssl@1.1
  pcre
  protobuf
  wolfssl
  xz
].freeze

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #block_size, #caveats_strings, #check_precedence, #class_name, #component_precedes?, #depends_on?, #depends_on_name_type?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #formula_tap, #get_checksum_node, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_called_in_block?, #method_name, #node_equals?, #offending_node, #on_class, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content, #versioned_formula?

Instance Method Details

#audit_formula(_node, _class_node, _parent_class_node, body_node) ⇒ Object 



537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
 
# File 'brew/Library/Homebrew/rubocops/lines.rb', line 537

def audit_formula(_node, _class_node, _parent_class_node, body_node)
  return if formula_tap != "homebrew-core"

  # Avoid build-time checks in homebrew/core
  find_every_method_call_by_name(body_node, :system).each do |method|
    next if @formula_name.start_with?("lib")
    next if MAKE_CHECK_ALLOWLIST.include?(@formula_name)

    params = parameters(method)
    next unless node_equals?(params[0], "make")

    params[1..].each do |arg|
      next unless regex_match_group(arg, /^(checks?|tests?)$/)

      offending_node(method)
      problem "Formulae in homebrew/core (except e.g. cryptography, libraries) " \
              "should not run build-time checks"
    end
  end
end