Class: RuboCop::Cop::FormulaAudit::Test

Inherits:
RuboCop::Cop::FormulaCop show all
Defined in:
brew/Library/Homebrew/rubocops/class.rb

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #block_size, #caveats_strings, #check_precedence, #class_name, #component_precedes?, #depends_on?, #depends_on_name_type?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #formula_tap, #get_checksum_node, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_called_in_block?, #method_name, #node_equals?, #offending_node, #on_class, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content, #versioned_formula?

Instance Method Details

#audit_formula(_node, _class_node, _parent_class_node, body_node) ⇒ Object 



30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
 
# File 'brew/Library/Homebrew/rubocops/class.rb', line 30

def audit_formula(_node, _class_node, _parent_class_node, body_node)
  test = find_block(body_node, :test)
  return unless test

  if test.body.nil?
    problem "`test do` should not be empty"
    return
  end

  problem "`test do` should contain a real test" if test.body.single_line? && test.body.source.to_s == "true"

  test_calls(test) do |node, params|
    p1, p2 = params
    if match = string_content(p1).match(%r{(/usr/local/(s?bin))})
      offending_node(p1)
      problem "use \#{#{match[2]}} instead of #{match[1]} in #{node}"
    end

    if node == :shell_output && node_equals?(p2, 0)
      offending_node(p2)
      problem "Passing 0 to shell_output() is redundant"
    end
  end
end

#autocorrect(node) ⇒ Object 



55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
 
# File 'brew/Library/Homebrew/rubocops/class.rb', line 55

def autocorrect(node)
  lambda do |corrector|
    case node.type
    when :str, :dstr
      # Rubocop: intentionally outputted non-interpolated strings
      corrector.replace(node.source_range,
                        node.source.to_s.sub(%r{(/usr/local/(s?bin))},
                                             '#{\2}')) # rubocop:disable Lint/InterpolationCheck
    when :int
      corrector.remove(
        range_with_surrounding_comma(
          range_with_surrounding_space(range: node.source_range,
                                       side:  :left),
        ),
      )
    end
  end
end