Class: RuboCop::Cop::FormulaAudit::ShellVariables

Inherits:
RuboCop::Cop::FormulaCop show all
Defined in:
brew/Library/Homebrew/rubocops/lines.rb

Instance Attribute Summary

Attributes inherited from RuboCop::Cop::FormulaCop

#file_path

Instance Method Summary collapse

Methods inherited from RuboCop::Cop::FormulaCop

#audit_comments, #audit_urls, #block_size, #caveats_strings, #check_precedence, #class_name, #component_precedes?, #depends_on?, #depends_on_name_type?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #formula_tap, #get_checksum_node, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_called_in_block?, #method_name, #node_equals?, #offending_node, #on_class, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content, #versioned_formula?

Instance Method Details

#audit_formula(_node, _class_node, _parent_class_node, body_node) ⇒ Object



234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
# File 'brew/Library/Homebrew/rubocops/lines.rb', line 234

def audit_formula(_node, _class_node, _parent_class_node, body_node)
  popen_commands = [
    :popen,
    :popen_read,
    :safe_popen_read,
    :popen_write,
    :safe_popen_write,
  ]

  popen_commands.each do |command|
    find_instance_method_call(body_node, "Utils", command) do |method|
      next unless match = regex_match_group(parameters(method).first, /^([^"' ]+)=([^"' ]+)(?: (.*))?$/)

      good_args = "Utils.#{command}({ \"#{match[1]}\" => \"#{match[2]}\" }, \"#{match[3]}\")"

      problem "Use `#{good_args}` instead of `#{method.source}`"
    end
  end
end

#autocorrect(node) ⇒ Object



254
255
256
257
258
259
# File 'brew/Library/Homebrew/rubocops/lines.rb', line 254

def autocorrect(node)
  lambda do |corrector|
    match = regex_match_group(node, /^([^"' ]+)=([^"' ]+)(?: (.*))?$/)
    corrector.replace(node.source_range, "{ \"#{match[1]}\" => \"#{match[2]}\" }, \"#{match[3]}\"")
  end
end