Class: RuboCop::Cop::Cask::OnSystemConditionals

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector, Forwardable
Includes:
CaskHelp, OnSystemConditionalsHelper
Defined in:
rubocops/cask/on_system_conditionals.rb

Overview

This cop makes sure that OS conditionals are consistent.

Examples:

# bad
cask 'foo' do
  if MacOS.version == :high_sierra
    sha256 "..."
  end
end

# good
cask 'foo' do
  on_high_sierra do
    sha256 "..."
  end
end

Constant Summary collapse

FLIGHT_STANZA_NAMES = 
[:preflight, :postflight, :uninstall_preflight, :uninstall_postflight].freeze

Constants included from OnSystemConditionalsHelper

OnSystemConditionalsHelper::ARCH_OPTIONS, OnSystemConditionalsHelper::BASE_OS_OPTIONS, OnSystemConditionalsHelper::MACOS_VERSION_CONDITIONALS, OnSystemConditionalsHelper::MACOS_VERSION_OPTIONS, OnSystemConditionalsHelper::ON_SYSTEM_OPTIONS

Instance Method Summary collapse

Methods included from CaskHelp

#find_end_line, #inner_stanzas, #on_block, #on_cask_stanza_block, #on_system_methods

Methods included from OnSystemConditionalsHelper

#audit_arch_conditionals, #audit_base_os_conditionals, #audit_macos_version_conditionals, #audit_on_system_blocks

Methods included from HelperFunctions

#block_method_called_in_block?, #block_size, #check_precedence, #class_name, #component_precedes?, #end_column, #expression_negated?, #find_all_blocks, #find_block, #find_blocks, #find_const, #find_every_func_call_by_name, #find_every_method_call_by_name, #find_instance_call, #find_instance_method_call, #find_method_calls_by_name, #find_method_def, #find_method_with_args, #find_node_method_by_name, #find_strings, #format_component, #line_number, #line_start_column, #method_called?, #method_called_ever?, #method_name, #node_equals?, #offending_node, #parameters, #parameters_passed?, #problem, #regex_match_group, #size, #source_buffer, #start_column, #string_content

Instance Method Details

#on_cask(cask_block) ⇒ Object 



34
35
36
37
38
39
40
41
42
43
44
45
46
 
# File 'rubocops/cask/on_system_conditionals.rb', line 34

def on_cask(cask_block)
  @cask_block = cask_block

  toplevel_stanzas.each do |stanza|
    next unless FLIGHT_STANZA_NAMES.include? stanza.stanza_name

    audit_on_system_blocks(stanza.stanza_node, stanza.stanza_name)
  end

  audit_arch_conditionals(cask_body)
  audit_macos_version_conditionals(cask_body, recommend_on_system: false)
  simplify_sha256_stanzas
end